Bug 46131

Summary:

[chromium] Remove GLES2Context and WebGLES2Context

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebCore Misc.

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hclam, jamesr, scherkus, senorblanco, vangelis, vrk

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

45912, 46231

Bug Blocks:

Attachments:

Description	Flags
Patch	jamesr: review+, kbr: commit-queue-

Kenneth Russell

Reported 2010-09-20 15:36:01 PDT

Now that Chromium's compositor has been switched over to use GraphicsContext3D for its rendering, the GLES2Context and WebGLES2Context abstractions need to be removed. Their presence is breaking the Windows multi-DLL build due to multiple inclusions of the command buffer client code and its thread-local variables.

Attachments
Patch (25.61 KB, patch) 2010-09-21 17:25 PDT, Kenneth Russell	jamesr: review+ kbr: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kenneth Russell

Comment 1 2010-09-21 17:25:20 PDT

Created attachment 68317 [details] Patch From the ChangeLog: Removed now-obsolete GLES2Context and WebGLES2Context classes, and dependency on command buffer client code from WebCore. Built and tested 3D CSS and WebGL content on Mac OS X to test.

James Robinson

Comment 2 2010-09-21 17:26:47 PDT

Comment on attachment 68317 [details] Patch R=me

Kenneth Russell

Comment 3 2010-09-21 17:34:50 PDT

Committed r68000: <http://trac.webkit.org/changeset/68000>

Note You need to log in before you can comment on or make changes to this bug.