Bug 46126

Summary: Add availableLogicalWidth to RenderBox.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46127, 46124    
Attachments:
Description Flags
Patch mitz: review+

Description Dave Hyatt 2010-09-20 14:55:23 PDT
availableLogicalWidth() needs to be implemented, since percentage padding depends on it.
Comment 1 Dave Hyatt 2010-09-20 15:28:56 PDT
Created attachment 68147 [details]
Patch
Comment 2 mitz 2010-09-20 15:31:24 PDT
Comment on attachment 68147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68147&action=review

> WebCore/rendering/RenderBox.cpp:1739
> +    if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow() == BottomToTopBlockFlow)

I think you should start considering RenderStyle::blockFlowAxis() or RenderStyle::isVerticalBlockFlow() or something.
Comment 3 Dave Hyatt 2010-09-20 15:36:27 PDT
Yeah I'll add isVerticalTextFlow() in another patch and fix this.

Fixed in r67886.