Bug 46126

Summary: Add availableLogicalWidth to RenderBox.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46127, 46124    
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2010-09-20 14:55:23 PDT
availableLogicalWidth() needs to be implemented, since percentage padding depends on it.
Attachments
Patch (3.85 KB, patch)
2010-09-20 15:28 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-20 15:28:56 PDT
Created attachment 68147 [details] Patch
mitz
Comment 2 2010-09-20 15:31:24 PDT
Comment on attachment 68147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68147&action=review > WebCore/rendering/RenderBox.cpp:1739 > + if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow() == BottomToTopBlockFlow) I think you should start considering RenderStyle::blockFlowAxis() or RenderStyle::isVerticalBlockFlow() or something.
Dave Hyatt
Comment 3 2010-09-20 15:36:27 PDT
Yeah I'll add isVerticalTextFlow() in another patch and fix this. Fixed in r67886.
Note You need to log in before you can comment on or make changes to this bug.