Bug 46093 – [Qt][Meta] DRT sideeffect revealed by r67762 - 23 layout tests fail

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

r67762 made 23 layout tests fail on Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r67848%20(20282)

http://trac.webkit.org/changeset/67762 - original patch
http://trac.webkit.org/changeset/67767 - buildfix
http://trac.webkit.org/changeset/67772 - buildfix
http://trac.webkit.org/changeset/67777 - regression fix
http://trac.webkit.org/changeset/67779 - buildfix

I tried to revert these changes locally, and all tests pass.

[Csaba Osztrogonác]

Tests skipped temporarily by http://trac.webkit.org/changeset/67851.

Tomorrow I'm going to check if there are real regression or 
we only should update the Qt specific expected files.

[Darin Adler]

The links don’t work so I wan’t able to see what the failures are like. What are they like?

Since this patch was simply moving code back to Frame where it had been for a years before, I imagine there must be some error I made.

[Csaba Osztrogonác]

(In reply to comment #2)
> The links don’t work so I wan’t able to see what the failures are like. What are they like?
Unfortunately the link above is broken, because the closing
parentheses isn't part of the href. I have no idea why not ...
But if you copy the whole link, it works.

It seems it isn't a regression, but a Qt-DRT sideeffect problem.
I can reproduce these fails if I run all tests, but
I can't if I run only these 23 tests. :(

This bug might be related to https://bugs.webkit.org/show_bug.cgi?id=42578

[Igor Trindade Oliveira]

I tested the skipped tests done by http://trac.webkit.org/changeset/67851
and now almost the tests are passing:

svg/custom/use-font-face-crash.svg - Needs changes on expected files like others plataforms does.

svg/zoom/text/zoom-coords-viewattr-01-b.svg - Crashing

tables/layering/paint-test-layering-1.html - passing
tables/layering/paint-test-layering-2.html - passing 
tables/mozilla/bugs/adforce_imgis_com.html - passing
tables/mozilla/bugs/bug50695-2.html - passing 
tables/mozilla/bugs/bug56201.html - passing
tables/mozilla/bugs/bug92647-2.html - passing
tables/mozilla/bugs/bug196870.html - needs changes on expected file like others plataforms does.
tables/mozilla/other/slashlogo.html - passing
tables/mozilla_expected_failures/bugs/bug23847.html - passing
transforms/2d/transform-2d.html - passing
transforms/2d/transform-fixed-container.html - passing
transitions/font-family-during-transition.html - passing
transitions/svg-text-shadow-transition.html - passing
http/tests/local/file-url-sent-as-referer.html - passing
http/tests/misc/error404.pl - passing
http/tests/misc/frame-access-during-load.html - passing
http/tests/misc/generated-content-inside-table.html - passing
http/tests/misc/iframe404.html - passing
http/tests/misc/location-replace-crossdomain.html - passing
+http/tests/misc/slow-loading-image-in-pattern.html - needs changes expected file like others plataforms does
http/tests/uri/css-href.php - passing


Could you confirm that?

[Igor Trindade Oliveira]

i tested the following layouttests after and before the http://trac.webkit.org/changeset/67762:

1) svg/custom/use-font-face-crash.svg
2) svg/zoom/text/zoom-coords-viewattr-01-b.svg
3) tables/mozilla/bugs/bug196870.htm
4) http/tests/misc/slow-loading-image-in-pattern.html

1) and 2) was failing and 3) and 4) was working so the problem on this tests was propably not caused by this commit 67762.

[Igor Trindade Oliveira]

This bug will be a meta bug to fix the skipped layout tests.

[Csaba Osztrogonác]

It is a very old and obsolete bug, all of these test were unskipped long time ago.