Bug 45914

Summary: [chromium] Expose separate GraphicsContext3DInternal.h
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebKit Misc.Assignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, senorblanco, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 45912    
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-09-16 12:11:07 PDT
Currently Chromium's GraphicsContext3DInternal, which holds the data members for the GraphicsContext3D implementation, is hidden within the GraphicsContext3D.cpp file. It is going to be necessary to add some accessors to this class which can be called from external code (specifically, the WebViewImpl), so it needs to be exposed in its own header.
Attachments
Patch (25.24 KB, patch)
2010-09-16 12:15 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-09-16 12:15:31 PDT
Created attachment 67827 [details] Patch
James Robinson
Comment 2 2010-09-16 12:18:49 PDT
Comment on attachment 67827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67827&action=prettypatch R=me > WebKit/chromium/src/GraphicsContext3DInternal.h:51 > + bool initialize(GraphicsContext3D::Attributes attrs, HostWindow* hostWindow); nit: don't name these params > WebKit/chromium/src/GraphicsContext3DInternal.h:62 > + void paintRenderingResultsToCanvas(CanvasRenderingContext* context); nit: don't name param
Kenneth Russell
Comment 3 2010-09-16 12:31:39 PDT
Committed r67650: <http://trac.webkit.org/changeset/67650>
Note You need to log in before you can comment on or make changes to this bug.