Bug 45881

Summary:

[Qt] Use PlatformStrategies to not break WebKit2

Product:

WebKit

Reporter:

Balazs Kelemen <kbalazs>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

45857

Bug Blocks:

Attachments:

Description	Flags
proposed patch	kling: review-
proposed patch v2	none

Balazs Kelemen

Reported 2010-09-16 05:21:22 PDT

There is a long standing bug that prevents us to have a working WebKit2 port in trunk. At http://trac.webkit.org/browser/trunk/WebCore/plugins/qt/PluginDataQt.cpp#L37 there is a cast that is invalid and crashing in WebKit2. The functionality of that piece of code is implementing the QWebPluginFactory API. For not breaking WebKit2 we should implement that in the WebKit level. We can do this with the help of PlatformStrategies (exactly PluginStrategy).

Attachments
proposed patch (19.23 KB, patch) 2010-09-16 05:52 PDT, Balazs Kelemen	kling: review-	Details Formatted Diff Diff
proposed patch v2 (18.87 KB, patch) 2010-09-16 06:52 PDT, Balazs Kelemen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Balazs Kelemen

Comment 1 2010-09-16 05:52:31 PDT

Created attachment 67786 [details] proposed patch

WebKit Review Bot

Comment 2 2010-09-16 05:58:39 PDT

Attachment 67786 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:39: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2010-09-16 06:13:52 PDT

Comment on attachment 67786 [details] proposed patch > - Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) > - Copyright (C) 2008 Collabora Ltd. All rights reserved. > ... > + * Copyright (C) 2009, 2010 University of Szeged I don't think this is entirely kosher, you're reusing code but removing the original copyright notices AND changing the license from LGPL to 2cBSD.

Balazs Kelemen

Comment 4 2010-09-16 06:52:57 PDT

Created attachment 67790 [details] proposed patch v2 Fixed copyrights.

Balazs Kelemen

Comment 5 2010-09-16 06:53:53 PDT

(In reply to comment #3) > (From update of attachment 67786 [details]) > > - Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) > > - Copyright (C) 2008 Collabora Ltd. All rights reserved. > > ... > > + * Copyright (C) 2009, 2010 University of Szeged > > I don't think this is entirely kosher, you're reusing code but removing the original copyright notices AND changing the license from LGPL to 2cBSD. Sorry for that, I did it accidentally.

WebKit Review Bot

Comment 6 2010-09-16 06:59:03 PDT

Attachment 67790 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Balazs Kelemen

Comment 7 2010-09-20 02:21:57 PDT

*** This bug has been marked as a duplicate of bug 45831 ***

Note You need to log in before you can comment on or make changes to this bug.