Bug 45717

Summary: chromium/skia: possible crash in ImageLayerChromium
Product: WebKit Reporter: Nico Weber <thakis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd, jamesr, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch for both Skia and CG none

Nico Weber
Reported 2010-09-13 16:17:50 PDT
Like https://bugs.webkit.org/show_bug.cgi?id=45714 , but for skia. The problem is that the dom owns the image, and when the image is removed from the dom, the layer tree is updated only asynchronously. Hence, the layer needs to ref the platform image.
Attachments
Proposed patch for both Skia and CG (5.57 KB, patch)
2010-09-15 19:48 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2010-09-14 10:21:54 PDT
Mac version of this bug is now fixed. This skia bug is still missing.
Nico Weber
Comment 2 2010-09-15 19:42:54 PDT
*** Bug 45869 has been marked as a duplicate of this bug. ***
Vangelis Kokkevis
Comment 3 2010-09-15 19:48:30 PDT
Created attachment 67764 [details] Proposed patch for both Skia and CG
WebKit Commit Bot
Comment 4 2010-09-16 08:58:53 PDT
Comment on attachment 67764 [details] Proposed patch for both Skia and CG Clearing flags on attachment: 67764 Committed r67625: <http://trac.webkit.org/changeset/67625>
WebKit Commit Bot
Comment 5 2010-09-16 08:58:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.