Bug 45652

Summary: LayoutTestController.dumpConfigurationForViewport should move to Internals
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, fsamuel, gustavo, kenneth, kpiascik, mifenton, mihaip, ossy, philn, rakuco, tonikitoo, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 70559, 72722    
Attachments:
Description Flags
Mark new viewport tests as failing rather then skip them
none
work in progress
none
Patch
none
Patch none

Pavel Podivilov
Reported 2010-09-13 04:26:29 PDT
[Chromium] viewport meta tag tests are failing http://trac.webkit.org/changeset/67376
Attachments
Mark new viewport tests as failing rather then skip them (1.49 KB, patch)
2010-09-15 04:20 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
work in progress (25.78 KB, patch)
2012-07-09 15:52 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (232.51 KB, patch)
2012-07-09 17:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (244.07 KB, patch)
2012-07-09 18:10 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2010-09-13 05:44:34 PDT
Some of the tests are currently skipped for Qt as they do not give the same result as on the iPhone according to the Opera guys.
Kenneth Rohde Christiansen
Comment 2 2010-09-13 06:26:05 PDT
Thanks Pavel for skipping the tests so far.
Pavel Podivilov
Comment 3 2010-09-15 04:20:52 PDT
Created attachment 67664 [details] Mark new viewport tests as failing rather then skip them
Yury Semikhatsky
Comment 4 2010-09-15 04:34:52 PDT
Comment on attachment 67664 [details] Mark new viewport tests as failing rather then skip them Clearing flags on attachment: 67664 Committed r67548: <http://trac.webkit.org/changeset/67548>
Yury Semikhatsky
Comment 5 2010-09-15 04:35:05 PDT
All reviewed patches have been landed. Closing bug.
Pavel Podivilov
Comment 6 2010-09-15 04:36:50 PDT
resolved -> unconfirmed
Mihai Parparita
Comment 7 2011-03-07 12:53:37 PST
Re-titling bug since it's a missing DRT/LayoutTestController feature.
Adam Barth
Comment 8 2012-07-09 15:41:07 PDT
The madness must end.
Adam Barth
Comment 9 2012-07-09 15:52:42 PDT
Created attachment 151336 [details] work in progress
Adam Barth
Comment 10 2012-07-09 17:36:49 PDT
Created attachment 151367 [details] Patch
Adam Barth
Comment 11 2012-07-09 17:41:16 PDT
Comment on attachment 151367 [details] Patch Actually, this patch will fail test 91. One sec.
Build Bot
Comment 12 2012-07-09 17:43:36 PDT
Comment on attachment 151367 [details] Patch Attachment 151367 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13164428
Build Bot
Comment 13 2012-07-09 17:54:03 PDT
Comment on attachment 151367 [details] Patch Attachment 151367 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13164432
Adam Barth
Comment 14 2012-07-09 18:10:51 PDT
Created attachment 151374 [details] Patch
Eric Seidel (no email)
Comment 15 2012-07-10 00:33:27 PDT
Comment on attachment 151374 [details] Patch LGTM.
Adam Barth
Comment 16 2012-07-10 00:36:06 PDT
Thanks for the review.
WebKit Review Bot
Comment 17 2012-07-10 00:56:16 PDT
Comment on attachment 151374 [details] Patch Clearing flags on attachment: 151374 Committed r122204: <http://trac.webkit.org/changeset/122204>
WebKit Review Bot
Comment 18 2012-07-10 00:56:24 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 19 2012-07-10 03:25:22 PDT
(In reply to comment #17) > (From update of attachment 151374 [details]) > Clearing flags on attachment: 151374 > > Committed r122204: <http://trac.webkit.org/changeset/122204> You missed to update a test - I did it: https://trac.webkit.org/changeset/122210
Konrad Piascik
Comment 20 2012-07-10 06:23:09 PDT
*** Bug 89984 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.