Summary: | Move code from WebKit-layer to DocumentLoader | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, fishd, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 29947 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-09-10 15:52:39 PDT
Created attachment 67252 [details]
work in progress
Comment on attachment 67252 [details] work in progress View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch > WebKit/chromium/src/WebFrameImpl.cpp:1017 > + m_frame->loader()->documentLoader()->commitDocumentData(data, length); I think you meant commitData here. (In reply to comment #2) > (From update of attachment 67252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67252&action=prettypatch > > > WebKit/chromium/src/WebFrameImpl.cpp:1017 > > + m_frame->loader()->documentLoader()->commitDocumentData(data, length); > I think you meant commitData here. Yep. Thanks. That was the original name, but the "document" part seemed redundant. :) Created attachment 67261 [details]
Patch
Comment on attachment 67261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch > WebCore/WebCore.xcodeproj/project.pbxproj:-20630 > - developmentRegion = English; not sure about this change. seems unrelated. otherwise, r=me (In reply to comment #5) > (From update of attachment 67261 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67261&action=prettypatch > > > WebCore/WebCore.xcodeproj/project.pbxproj:-20630 > > - developmentRegion = English; > not sure about this change. seems unrelated. This is a commit war between different versions of Xcode. The consensus last time we discussed it as a community was to just have the commit war and eventually the bug in Xcode will be fixed. Comment on attachment 67261 [details] Patch Clearing flags on attachment: 67261 Committed r67253: <http://trac.webkit.org/changeset/67253> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/67253 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/67253 http://trac.webkit.org/changeset/67254 http://trac.webkit.org/changeset/67255 |