Bug 45481

Summary:

Inline FrameLoader::committedLoad into its one caller

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, japhet, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

29947

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Adam Barth 2010-09-09 11:37:04 PDT

Inline FrameLoader::committedLoad into its one caller

Comment 1 Adam Barth 2010-09-09 11:39:04 PDT

Created attachment 67072 [details]
Patch

Comment 2 Early Warning System Bot 2010-09-09 11:50:28 PDT

Attachment 67072 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3943343

Comment 3 Eric Seidel (no email) 2010-09-09 12:01:13 PDT

Attachment 67072 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3921337

Comment 4 Eric Seidel (no email) 2010-09-09 12:11:08 PDT

Comment on attachment 67072 [details]
Patch

It appears you're missing an include?
../../../WebCore/loader/DocumentLoader.cpp: In member function 'void WebCore::DocumentLoader::commitLoad(const char*, int)':
../../../WebCore/loader/DocumentLoader.cpp:285: error: invalid use of incomplete type 'struct WebCore::FrameLoaderClient'
../../../WebCore/loader/SubframeLoader.h:45: error: forward declaration of 'struct WebCore::FrameLoaderClient'

Otherwise seems fine.

Comment 5 Adam Barth 2010-09-09 12:18:41 PDT

Created attachment 67077 [details]
Patch for landing

Comment 6 Eric Seidel (no email) 2010-09-09 14:42:17 PDT

ews hung on this patch:

Failed to run "['WebKitTools/Scripts/build-webkit', '--release']" exit_code: 1
Adding comment to bug 45481

Comment 7 WebKit Commit Bot 2010-09-10 07:30:53 PDT

Comment on attachment 67077 [details]
Patch for landing

Clearing flags on attachment: 67077

Committed r67198: <http://trac.webkit.org/changeset/67198>

Comment 8 WebKit Commit Bot 2010-09-10 07:30:58 PDT

All reviewed patches have been landed.  Closing bug.