Bug 45321 – Current l10n infrastructure not completely intltool compliant

• Component: WebKitGTK
• Status: RESOLVED DUPLICATE

The /WebKit/gtk/po is currently not intltool compliant. The POTFILES must be named POTFILES.in (and you can also add an empty POTFILES.skip, in case you want to blacklist some files). Here is a working POTFILES.in:

# List of source files which contain translatable strings.
WebCoreSupport/ChromeClientGtk.cpp
WebCoreSupport/ContextMenuClientGtk.cpp
WebCoreSupport/FrameLoaderClientGtk.cpp
WebCoreSupport/FullscreenVideoController.cpp
webkit/webkitdownload.cpp
webkit/webkithittestresult.cpp
webkit/webkitnetworkrequest.cpp
webkit/webkitnetworkresponse.cpp
webkit/webkitsecurityorigin.cpp
webkit/webkitsoupauthdialog.c
webkit/webkitwebdatabase.cpp
webkit/webkitwebframe.cpp
webkit/webkitwebhistoryitem.cpp
webkit/webkitwebinspector.cpp
webkit/webkitwebnavigationaction.cpp
webkit/webkitwebresource.cpp
webkit/webkitwebsettings.cpp
webkit/webkitwebview.cpp
../../WebCore/platform/gtk/LocalizedStringsGtk.cpp

After those changes, we may be able to generate stats again on http://l10n.gnome.org/module/webkit/

[Priit Laes (IRC: plaes)]

Created attachment 103364 [details]
webkit-gtk-intltoolize.patch

This is a bit hacky version of adding intltool support for l10n infrastructure.

Why hacky? Because currently intltool only support po-directories on top-level of $srcdir. :(

[Gustavo Noronha (kov)]

Comment on attachment 103364 [details]
webkit-gtk-intltoolize.patch

Attachment 103364 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9336287

[Martin Robinson]

Alex, you're looked at the intltool stuff before. Maybe you could take a look at this patch?

[Eric Seidel (no email)]

Curious what the status here is and if it should still be up for review 4 months later?

[Gustavo Noronha (kov)]

*** Bug 66764 has been marked as a duplicate of this bug. ***

[Priit Laes (IRC: plaes)]

Created attachment 125667 [details]
webkit-intltool.patch

Hack warning: it works by 'faking' the path for intltool files directory by creating a symlink from original 'po' directory to to $topdir/po.

Although it's a hack it seems that everything went better than expected, because po-files get automatically build and installed and even `make dist` seems to work.

Seems to have been solved in #67580

*** This bug has been marked as a duplicate of bug 67580 ***