Summary: | http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, eric, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 45109 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Zhenyao Mo
2010-09-02 15:33:15 PDT
Created attachment 66499 [details]
patch
Manually committed r66735: http://trac.webkit.org/changeset/66735 http://trac.webkit.org/changeset/66735 might have broken Qt Linux Release + Changed MIME type for .js to application/x-javascript in lighttpd.conf for + consistency with apache used on other platforms. This patch seems to be doing a lot more than that. Comment on attachment 66499 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=66499&action=prettypatch > LayoutTests/ChangeLog:6 > + Use CGI as target for POST request to prevent HTTP 405 on certain platforms. Which platforms? Please list in your ChangeLog. (In reply to comment #4) > + Changed MIME type for .js to application/x-javascript in lighttpd.conf for > + consistency with apache used on other platforms. > > This patch seems to be doing a lot more than that. Alexey, you're quoting WebKitTools/ChangeLog. The rest of the change applies to LayoutTests and is summarized in LayoutTests/ChangeLog as "Use CGI as target for POST request to prevent HTTP 405 on certain platforms." I was actually quoting the latter, and I overlooked this part. Maybe just sloppiness on my part, but this also highlights why we ask for per-file or per-funciton comments in ChangeLogs. Updated LayoutTests/ChangeLog to include more details, committed as r66749: http://trac.webkit.org/changeset/66749 Thank you. |