Bug 45109

Summary: Web Inspector: HAR converter fails on POST requests with non-form content type
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 45137    
Attachments:
Description Flags
Patch yurys: review+

Andrey Kosyakov
Reported 2010-09-02 07:04:40 PDT
HAREntry.convert() fails in HAREntry._buildParameters() when passed a resource that has POST data with content-type other application/x-www-form-urlencoded. The problem currently appears only in extensions that request resource data when inspecting sites that do XHRs.
Attachments
Patch (10.91 KB, patch)
2010-09-02 07:22 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2010-09-02 07:22:41 PDT
Created attachment 66368 [details] Patch
WebKit Review Bot
Comment 2 2010-09-02 09:08:49 PDT
http://trac.webkit.org/changeset/66669 might have broken SnowLeopard Intel Release (Tests)
Joseph Pecoraro
Comment 3 2010-09-02 09:55:23 PDT
Andrey, when you land a patch please update the Bugzilla bug with a link to trac and move its state from "unconfirmed" to "resolved > fixed". Is that the case here?
Andrey Kosyakov
Comment 4 2010-09-02 11:02:04 PDT
(In reply to comment #3) > Andrey, when you land a patch please update the Bugzilla bug > with a link to trac and move its state from "unconfirmed" to > "resolved > fixed". Is that the case here? Thanks, I normally do this, I was just waiting for a follow-up patch with the test fix to land.
Andrey Kosyakov
Comment 5 2010-09-02 11:04:38 PDT
Manually committed r66669: http://trac.webkit.org/changeset/66669 Test fix committed as r66672: http://trac.webkit.org/changeset/66672
Joseph Pecoraro
Comment 6 2010-09-02 11:06:07 PDT
> Thanks, I normally do this, I was just waiting for a follow-up patch > with the test fix to land. I see. In any case, posting the trac link as soon as a patch lands is more useful than marking the bug resolved. I often do the same thing, I land, post some info on the bug and let them know I'm "watching the bots", and mark it resolved a little later when the bots have passed.
Note You need to log in before you can comment on or make changes to this bug.