| Summary: | check-webkit-style should understand WTF #include guards | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, crogers, eric, hamaji, levin | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 44892 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 76830 [details]
Patch
Comment on attachment 76830 [details]
Patch
LGTM. Thanks.
Comment on attachment 76830 [details] Patch Clearing flags on attachment: 76830 Committed r74255: <http://trac.webkit.org/changeset/74255> All reviewed patches have been landed. Closing bug. |
Many of the files in JavaScriptCore/wtf use a different #include guard than those used in WebCore; e.g., "#ifndef WTF_Vector_h" rather than "#ifndef Vector_h". This does seem to be a good idea to avoid clashes between potentially similarly-named headers in WTF and WebCore, since the #include style is different ('#include <wtf/Vector.h>' rather than '#include "Vector.h"'). check-webkit-style complains about the addition of new WTF_ prefixed #include guards; I think it should be taught about them. See https://bugs.webkit.org/show_bug.cgi?id=44892 for one instance where it complained.