Bug 44911

Summary: check-webkit-style should understand WTF #include guards
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, crogers, eric, hamaji, levin
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 44892    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2010-08-30 17:21:14 PDT
Many of the files in JavaScriptCore/wtf use a different #include guard than those used in WebCore; e.g., "#ifndef WTF_Vector_h" rather than "#ifndef Vector_h". This does seem to be a good idea to avoid clashes between potentially similarly-named headers in WTF and WebCore, since the #include style is different ('#include <wtf/Vector.h>' rather than '#include "Vector.h"'). check-webkit-style complains about the addition of new WTF_ prefixed #include guards; I think it should be taught about them. See https://bugs.webkit.org/show_bug.cgi?id=44892 for one instance where it complained.
Attachments
Patch (4.80 KB, patch)
2010-12-16 16:59 PST, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-12-16 16:59:06 PST
Created attachment 76830 [details] Patch
Eric Seidel (no email)
Comment 2 2010-12-17 03:56:43 PST
Comment on attachment 76830 [details] Patch LGTM. Thanks.
WebKit Commit Bot
Comment 3 2010-12-17 05:15:50 PST
Comment on attachment 76830 [details] Patch Clearing flags on attachment: 76830 Committed r74255: <http://trac.webkit.org/changeset/74255>
WebKit Commit Bot
Comment 4 2010-12-17 05:15:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.