Bug 44840

Summary:

[chromium] Create webcore_svg with all the svg sources.

Product:

WebKit

Reporter:

Marc-Antoine Ruel <maruel>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

44814

Bug Blocks:

Attachments:

Description	Flags
webcore.gyp patch	tkent: review+, tkent: commit-queue-

Marc-Antoine Ruel

Reported 2010-08-29 08:24:03 PDT

Remove svg sources from webcore_remaining and move them to webcore_svg.

Attachments
webcore.gyp patch (3.94 KB, patch) 2010-08-29 13:17 PDT, Marc-Antoine Ruel	tkent: review+ tkent: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Marc-Antoine Ruel

Comment 1 2010-08-29 13:17:51 PDT

Created attachment 65861 [details] webcore.gyp patch Is http://codereview.chromium.org/3215007/show patchset 5. Compiles on all platforms in both incremental and clobber build. Requires the dependent bugs to be checked in first.

Kent Tamura

Comment 2 2010-08-30 00:31:20 PDT

Comment on attachment 65861 [details] webcore.gyp patch Looks ok.

Kent Tamura

Comment 3 2010-08-30 00:32:18 PDT

Comment on attachment 65861 [details] webcore.gyp patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 816360a..a67a88d 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,12 @@ > +2010-08-29 Marc-Antoine Ruel <maruel@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Split webcore_svg off webcore_remaining. webcore_svg contains all svg > + sources files. > + > + * WebCore.gyp/WebCore.gyp: > + Should add the bug URL to the ChangeLog entry.

Kent Tamura

Comment 4 2010-08-30 00:47:35 PDT

Landed: http://trac.webkit.org/changeset/66373

Note You need to log in before you can comment on or make changes to this bug.