Bug 44814

Summary:

[chromium] Move all the remaining dependencies in webcore_remaining into webcore_prerequisites

Product:

WebKit

Reporter:

Marc-Antoine Ruel <maruel>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, dglazkov, eric, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

44812

Bug Blocks:

44840

Attachments:

Description	Flags
webcore.gyp patch	none
webcore.gyp patch	dglazkov: review+, commit-queue: commit-queue-
webcore.gyp patch	tkent: review+, tkent: commit-queue-

Marc-Antoine Ruel

Reported 2010-08-27 21:33:36 PDT

Move all the remaining dependencies in webcore_remaining into webcore_prerequisites

Attachments
webcore.gyp patch (4.21 KB, patch) 2010-08-27 21:36 PDT, Marc-Antoine Ruel	no flags	Details Formatted Diff Diff
webcore.gyp patch (4.21 KB, patch) 2010-08-27 22:00 PDT, Marc-Antoine Ruel	dglazkov: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
webcore.gyp patch (3.96 KB, patch) 2010-08-29 08:20 PDT, Marc-Antoine Ruel	tkent: review+ tkent: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Marc-Antoine Ruel

Comment 1 2010-08-27 21:36:52 PDT

Created attachment 65809 [details] webcore.gyp patch

Marc-Antoine Ruel

Comment 2 2010-08-27 21:39:35 PDT

Original code review http://codereview.chromium.org/3225004

Marc-Antoine Ruel

Comment 3 2010-08-27 22:00:32 PDT

Created attachment 65811 [details] webcore.gyp patch Rebase against HEAD

Dimitri Glazkov (Google)

Comment 4 2010-08-28 08:03:27 PDT

Comment on attachment 65811 [details] webcore.gyp patch ok.

WebKit Commit Bot

Comment 5 2010-08-28 08:36:16 PDT

Comment on attachment 65811 [details] webcore.gyp patch Rejecting patch 65811 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/WebCore.gyp/WebCore.gyp Hunk #1 FAILED at 873. Hunk #2 FAILED at 887. Hunk #3 FAILED at 920. Hunk #4 FAILED at 956. Hunk #5 FAILED at 1111. Hunk #6 succeeded at 1083 (offset -42 lines). Hunk #7 FAILED at 1099. Hunk #8 succeeded at 1267 with fuzz 1 (offset 6 lines). 6 out of 8 hunks FAILED -- saving rejects to file WebCore/WebCore.gyp/WebCore.gyp.rej Full output: http://queues.webkit.org/results/3885073

Marc-Antoine Ruel

Comment 6 2010-08-29 08:20:30 PDT

Created attachment 65853 [details] webcore.gyp patch http://codereview.chromium.org/3225004 patchset 3.

Kent Tamura

Comment 7 2010-08-30 00:27:51 PDT

Comment on attachment 65853 [details] webcore.gyp patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 2da30fe..816360a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -2,6 +2,14 @@ > > Reviewed by NOBODY (OOPS!). > > + Move most dependencies to webcore_prerequisites > + > + * WebCore.gyp/WebCore.gyp: > + > +2010-08-27 Marc-Antoine Ruel <maruel@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > Move more common settings to webcore_prerequisites > > * WebCore.gyp/WebCore.gyp: Please add the bug URL to the ChangeLog entry.

Kent Tamura

Comment 8 2010-08-30 00:29:08 PDT

Landed: http://trac.webkit.org/changeset/66370

WebKit Review Bot

Comment 9 2010-08-30 01:00:19 PDT

http://trac.webkit.org/changeset/66370 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/66369 http://trac.webkit.org/changeset/66370

Note You need to log in before you can comment on or make changes to this bug.