Bug 44696

Summary:

Misc. cleanup from bug 32356

Product:

WebKit

Reporter:

Peter Kasting <pkasting>

Component:

WebCore Misc.

Assignee:

Peter Kasting <pkasting>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch v1	none
patch v1.1	dglazkov: review+, dglazkov: commit-queue+
patch v1.2	dglazkov: review+, commit-queue: commit-queue-

Peter Kasting

Reported 2010-08-26 11:10:33 PDT

While working on bug 32356, I've touched a lot of code. This bug is to hold a cleanup patch that splits out the non-functional changes I've made (e.g. style guide compliance, better line wrapping, etc.)

Attachments
patch v1 (18.99 KB, patch) 2010-08-26 11:17 PDT, Peter Kasting	no flags	Details Formatted Diff Diff
patch v1.1 (18.98 KB, patch) 2010-08-26 11:21 PDT, Peter Kasting	dglazkov: review+ dglazkov: commit-queue+	Details Formatted Diff Diff
patch v1.2 (18.97 KB, patch) 2010-08-26 11:47 PDT, Peter Kasting	dglazkov: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Peter Kasting

Comment 1 2010-08-26 11:17:27 PDT

Created attachment 65583 [details] patch v1

WebKit Review Bot

Comment 2 2010-08-26 11:18:48 PDT

Attachment 65583 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/Scrollbar.cpp:150: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] WebCore/platform/Scrollbar.cpp:149: Missing space before ( in switch( [whitespace/parens] [5] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Peter Kasting

Comment 3 2010-08-26 11:21:37 PDT

Created attachment 65585 [details] patch v1.1 Fix style errors.

Dimitri Glazkov (Google)

Comment 4 2010-08-26 11:36:34 PDT

Comment on attachment 65585 [details] patch v1.1 ok.

Eric Seidel (no email)

Comment 5 2010-08-26 11:40:08 PDT

Attachment 65583 [details] did not build on mac: Build output: http://queues.webkit.org/results/3789566

Peter Kasting

Comment 6 2010-08-26 11:47:07 PDT

Created attachment 65591 [details] patch v1.2 Fix Mac build error due to (wrong) compiler warning. Carrying over dglazkov's r+ and cq+.

Dimitri Glazkov (Google)

Comment 7 2010-08-26 12:37:09 PDT

Comment on attachment 65591 [details] patch v1.2 cycling the rrrr.

WebKit Commit Bot

Comment 8 2010-08-27 08:05:49 PDT

Comment on attachment 65591 [details] patch v1.2 Rejecting patch 65591 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 1 Last 500 characters of output: rImpl.cpp Hunk #1 FAILED at 81. Hunk #2 FAILED at 214. 2 out of 2 hunks FAILED -- saving rejects to file WebKit/chromium/src/WebScrollbarImpl.cpp.rej patching file WebKit/chromium/src/WebViewImpl.cpp Hunk #1 FAILED at 823. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/WebViewImpl.cpp.rej patching file WebKit/chromium/src/win/WebInputEventFactory.cpp Hunk #1 FAILED at 398. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/win/WebInputEventFactory.cpp.rej Full output: http://queues.webkit.org/results/3851023

Peter Kasting

Comment 9 2010-08-27 10:04:41 PDT

Shoot, I forgot to mark this fixed. I landed this in r66126.

Note You need to log in before you can comment on or make changes to this bug.