Bug 44609 – [EFL] Add linker script to export less symbols

• Component: New Bugs
• Status: RESOLVED FIXED

[Lucas De Marchi]

[EFL] Add linker script to export less symbols

[Lucas De Marchi]

Created attachment 65414 [details]
Patch

[Lucas De Marchi]

Some numbers about the exported symbols (nm -D WebKit/libewebkit.so |  wc -l):


                 |  SHARED_CORE=ON  | SHARED_CORE=OFF
=======================================================
   linker script |             716  |             959
no linker script |            1110  |            1073

[Lucas De Marchi]

CCing the gtk guys who did the linker script for autotools.

Why aren't you using the 'extern "C++" { };' in your script?

[Holger Freyther]

Maybe you should stop using internal WebCore types first and then worry about exporting symbols?

Regarding the 'extern "C++" {}'. I didn't know it, gcc on debian had a bug that it made the new/delete operator have external linkage and we solved it by filtering out _Z*.

[Lucas De Marchi]

(In reply to comment #4)
> Maybe you should stop using internal WebCore types first and then worry about exporting symbols?

At a first look, I thought it would be harder than it is. So I sent this patch first. It turned out that it's not that hard. I'm preparing a patch to fix that and after I'll send a new patch on this bug

> 
> Regarding the 'extern "C++" {}'. I didn't know it, gcc on debian had a bug that it made the new/delete operator have external linkage and we solved it by filtering out _Z*.

These one I think it's ok, because it's the way you differentiate C++ from C. But I was talking about the exceptions for fastRealloc, fastMalloc etc. IMHO, those would be nicer if they were demangled by linker.

[Lucas De Marchi]

Comment on attachment 65414 [details]
Patch

Not good. Clearing flags.

[Lucas De Marchi]

Created attachment 66483 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 66483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66483&action=review

Seems OK otherwise.

> ChangeLog:5
> +        [EFL] Add linker script to export less symbols

fewer, not less.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 66483 [details]:

transitions/transition-end-event-transform.html bug 51024 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 66483 [details]
Patch

Clearing flags on attachment: 66483

Committed r74012: <http://trac.webkit.org/changeset/74012>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas De Marchi]

(In reply to comment #11)
> All reviewed patches have been landed.  Closing bug.

Eric, did you see this bug depended on other open bugs?


Now that this patch is in, I'll let it like this. I'll have to partially revert this one when the other patches make it.