Bug 44220

Summary:

dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

enrica, eric, ojan, tkent, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

24009, 26483

Attachments:

Description	Flags
converts the tests	none
fixed per Ojan's comment	none
Removed dump-as-markup change	tony: review+

Ryosuke Niwa

Reported 2010-08-18 17:05:36 PDT

editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html should be dumpAsMarkup tests because neither tests need to verify the rendering.

Attachments
converts the tests (32.14 KB, patch) 2010-08-18 17:20 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
fixed per Ojan's comment (32.13 KB, patch) 2010-08-18 19:17 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Removed dump-as-markup change (31.25 KB, patch) 2010-08-18 19:19 PDT, Ryosuke Niwa	tony: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2010-08-18 17:20:14 PDT

Created attachment 64792 [details] converts the tests

Eric Seidel (no email)

Comment 2 2010-08-18 17:33:56 PDT

Comment on attachment 64792 [details] converts the tests Are you sure your new editing/pasteboard/4242293-1-expected.txt are right? The two regions don't match.

Ryosuke Niwa

Comment 3 2010-08-18 17:36:30 PDT

(In reply to comment #2) > (From update of attachment 64792 [details]) > Are you sure your new editing/pasteboard/4242293-1-expected.txt are right? The two regions don't match. Yes. By identical contents, we mean that they look alike, not identical DOM tree.

Ojan Vafai

Comment 4 2010-08-18 18:19:23 PDT

Comment on attachment 64792 [details] converts the tests Can you change the text in 4242293-1.html to say that they should be visually identical? Your change obviously isn't causing the test case to fail. Also, can you move the dump-as-markup.js change into a separate patch?

Ryosuke Niwa

Comment 5 2010-08-18 18:56:42 PDT

(In reply to comment #4) > (From update of attachment 64792 [details]) > Can you change the text in 4242293-1.html to say that they should be visually identical? Your change obviously isn't causing the test case to fail. Will do. > Also, can you move the dump-as-markup.js change into a separate patch? Filed the bug 44225. Will submit a patch shortly.

Ryosuke Niwa

Comment 6 2010-08-18 19:17:45 PDT

Created attachment 64800 [details] fixed per Ojan's comment

Ryosuke Niwa

Comment 7 2010-08-18 19:19:22 PDT

Created attachment 64801 [details] Removed dump-as-markup change

Ryosuke Niwa

Comment 8 2010-08-19 15:02:14 PDT

Thanks Tony!

Ryosuke Niwa

Comment 9 2010-08-19 18:22:44 PDT

Committed r65721: <http://trac.webkit.org/changeset/65721>

Note You need to log in before you can comment on or make changes to this bug.