Summary: | Perl warnings when running commit-log-editor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, eric, hyatt, tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2010-08-11 09:16:53 PDT
Created attachment 64123 [details]
Patch
Perl doesn't have symbolic names for True/False. Instead, we should use boolean values. Moreover, the variable installedEditorApplication is unused. It looks like it should be renamed builtEditorApplication so that it uses the existing machinery to set the editor.
This patch addresses some of the errors, but not these: "Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85. Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86." I still can't commit. Help! Committed in changeset 65179 <http://trac.webkit.org/changeset/65179>. Comment on attachment 64123 [details]
Patch
Clearing commit-queue flag since I committed this by hand because the queue was slow today :-(
(In reply to comment #2) > This patch addresses some of the errors, but not these: > > "Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85. > Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86." > > I still can't commit. Help! Spoke with David Hyatt on IRC. He inadvertently did not copy over the change to rename the variable installedEditorApplication to builtEditorApplication (included in this patch). He confirmed that his change resolves the "Global symbol" warnings. |