Bug 43733

Summary: Add suspendAnimations/resumeAnimation API to DRT
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: Tools / TestsAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, gustavo, ossy, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 43792    
Attachments:
Description Flags
Patch with test case
none
Replacement patch to fix builds
none
Patch with fix for gtk build oliver: review+

Chris Marrin
Reported 2010-08-09 11:17:43 PDT
The AnimationController has an API to suspend and resume animations. This is for embedding apps to get control over the animation when needed. The API is not testable, so we should add API to LayoutTestController in DRT to allow it to be tested.
Attachments
Patch with test case (26.36 KB, patch)
2010-08-10 08:25 PDT, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Replacement patch to fix builds (29.85 KB, patch)
2010-08-10 12:25 PDT, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Patch with fix for gtk build (30.65 KB, patch)
2010-08-10 15:13 PDT, Chris Marrin 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2010-08-10 07:38:30 PDT
I'm about to submit a patch for this fix. I've added the required logic on all platforms, but I can only test on Mac, so other builds could be broken. I believe I've added all the source changes, but at least the Qt build will need additions of symbols to WebKit/qt/symbian/bwins/QtWebKitu.def and WebKit/qt/symbian/eabi/QtWebKitu.def.
Chris Marrin
Comment 2 2010-08-10 08:00:12 PDT
*** Bug 42790 has been marked as a duplicate of this bug. ***
Chris Marrin
Comment 3 2010-08-10 08:25:38 PDT
Created attachment 64014 [details] Patch with test case
WebKit Review Bot
Comment 4 2010-08-10 09:01:55 PDT
Attachment 64014 [details] did not build on chromium: Build output: http://queues.webkit.org/results/3703029
WebKit Review Bot
Comment 5 2010-08-10 09:07:09 PDT
Attachment 64014 [details] did not build on gtk: Build output: http://queues.webkit.org/results/3767031
WebKit Review Bot
Comment 6 2010-08-10 10:06:45 PDT
Attachment 64014 [details] did not build on win: Build output: http://queues.webkit.org/results/3705038
Chris Marrin
Comment 7 2010-08-10 12:25:22 PDT
Created attachment 64038 [details] Replacement patch to fix builds
WebKit Review Bot
Comment 8 2010-08-10 15:06:04 PDT
Attachment 64038 [details] did not build on gtk: Build output: http://queues.webkit.org/results/3736038
Chris Marrin
Comment 9 2010-08-10 15:13:01 PDT
Created attachment 64050 [details] Patch with fix for gtk build
WebKit Review Bot
Comment 10 2010-08-10 16:56:25 PDT
Attachment 64050 [details] did not build on gtk: Build output: http://queues.webkit.org/results/3719044
Oliver Hunt
Comment 11 2010-08-10 17:16:06 PDT
Comment on attachment 64050 [details] Patch with fix for gtk build r=me
Chris Marrin
Comment 12 2010-08-10 18:04:20 PDT
Committed r65107: <http://trac.webkit.org/changeset/65107>
WebKit Review Bot
Comment 13 2010-08-10 18:11:40 PDT
http://trac.webkit.org/changeset/65107 might have broken Chromium Linux Release
Eric Seidel (no email)
Comment 14 2010-08-10 23:57:59 PDT
This appears to have also broken Qt, if i'm reading the bot correctly.
Csaba Osztrogonác
Comment 15 2010-08-11 04:20:05 PDT
(In reply to comment #14) > This appears to have also broken Qt, if i'm reading the bot correctly. animations/suspend-resume-animation.html still fails on Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r65142%20%2817459%29/animations/suspend-resume-animation-pretty-diff.html It might be related to https://bugs.webkit.org/show_bug.cgi?id=42821 , because the diffs are so similar.
Csaba Osztrogonác
Comment 16 2010-08-12 09:58:38 PDT
(In reply to comment #14) > This appears to have also broken Qt, if i'm reading the bot correctly. New bug filed: https://bugs.webkit.org/show_bug.cgi?id=43905
Note You need to log in before you can comment on or make changes to this bug.