Bug 43360

Summary:

[Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, lkcl, tonikitoo

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

Windows XP

Bug Depends on:

Bug Blocks:

43191

Attachments:

Description	Flags
proposed fix	none

Csaba Osztrogonác

Reported 2010-08-02 09:42:15 PDT

In file included from ..\..\..\WebCore\platform\qt\PlatformKeyboardEventQt.cpp:32:0: ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:37:0: warning: "VK_BACK" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1869:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:38:0: warning: "VK_TAB" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1870:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:39:0: warning: "VK_CLEAR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1871:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:40:0: warning: "VK_RETURN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1872:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:41:0: warning: "VK_SHIFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1873:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:42:0: warning: "VK_CONTROL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1874:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:43:0: warning: "VK_MENU" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1875:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:44:0: warning: "VK_PAUSE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1876:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:45:0: warning: "VK_CAPITAL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1877:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:57:0: warning: "VK_SPACE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1890:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:58:0: warning: "VK_PRIOR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1891:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:59:0: warning: "VK_NEXT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1892:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:60:0: warning: "VK_END" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1893:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:61:0: warning: "VK_HOME" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1894:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:62:0: warning: "VK_LEFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1895:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:63:0: warning: "VK_UP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1896:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:64:0: warning: "VK_RIGHT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1897:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:65:0: warning: "VK_DOWN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1898:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:66:0: warning: "VK_SELECT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1899:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:67:0: warning: "VK_PRINT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1900:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:68:0: warning: "VK_EXECUTE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1901:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:69:0: warning: "VK_SNAPSHOT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1902:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:70:0: warning: "VK_INSERT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1903:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:71:0: warning: "VK_DELETE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1904:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:72:0: warning: "VK_HELP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1905:0: note: this is the location of the previous definition In file included from ..\..\..\WebKit\qt\WebCoreSupport\EditorClientQt.cpp:49:0: ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:37:0: warning: "VK_BACK" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1869:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:38:0: warning: "VK_TAB" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1870:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:39:0: warning: "VK_CLEAR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1871:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:40:0: warning: "VK_RETURN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1872:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:41:0: warning: "VK_SHIFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1873:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:42:0: warning: "VK_CONTROL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1874:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:43:0: warning: "VK_MENU" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1875:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:44:0: warning: "VK_PAUSE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1876:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:45:0: warning: "VK_CAPITAL" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1877:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:57:0: warning: "VK_SPACE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1890:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:58:0: warning: "VK_PRIOR" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1891:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:59:0: warning: "VK_NEXT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1892:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:60:0: warning: "VK_END" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1893:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:61:0: warning: "VK_HOME" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1894:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:62:0: warning: "VK_LEFT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1895:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:63:0: warning: "VK_UP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1896:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:64:0: warning: "VK_RIGHT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1897:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:65:0: warning: "VK_DOWN" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1898:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:66:0: warning: "VK_SELECT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1899:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:67:0: warning: "VK_PRINT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1900:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:68:0: warning: "VK_EXECUTE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1901:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:69:0: warning: "VK_SNAPSHOT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1902:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:70:0: warning: "VK_INSERT" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1903:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:71:0: warning: "VK_DELETE" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1904:0: note: this is the location of the previous definition ..\..\..\WebCore\platform/WindowsKeyboardCodes.h:72:0: warning: "VK_HELP" redefined c:\mingw-45\bin\../lib/gcc/mingw32/4.5.0/../../../../include/winuser.h:1905:0: note: this is the location of the previous definition VK_xxx macros also defined in mingw/include/winuser.h. We should use these defines when we use MinGW, or #undef macros before defining them in WindowsKeyboardCodes.h

Attachments
proposed fix (1.52 KB, patch) 2010-08-03 04:15 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2010-08-02 09:56:28 PDT

*** This bug has been marked as a duplicate of bug 20721 ***

Csaba Osztrogonác

Comment 2 2010-08-03 04:14:20 PDT

Reopened, because https://bugs.webkit.org/show_bug.cgi?id=20721 is obsolete, defining VK_XXX macros changed.

Csaba Osztrogonác

Comment 3 2010-08-03 04:15:11 PDT

Created attachment 63319 [details] proposed fix

Csaba Osztrogonác

Comment 4 2010-08-03 04:15:58 PDT

*** Bug 20721 has been marked as a duplicate of this bug. ***

Csaba Osztrogonác

Comment 5 2010-08-08 15:27:31 PDT

Comment on attachment 63319 [details] proposed fix Clearing flags on attachment: 63319 Committed r64957: <http://trac.webkit.org/changeset/64957>

Csaba Osztrogonác

Comment 6 2010-08-08 15:27:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.