Bug 43353

Summary: generate-bindings.pl should generate warning free code
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, eric, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43191    
Attachments:
Description Flags
proposed fix none

Csaba Osztrogonác
Reported 2010-08-02 08:39:58 PDT
WebCore/generated/JSBlobBuilder.cpp is generated by WebCore/bindings/scripts/generate-bindings.pl, and gcc-4.3.2 reports this warning: generated/JSBlobBuilder.cpp: In function ‘JSC::EncodedJSValue WebCore::jsBlobBuilderPrototypeFunctionAppend(JSC::ExecState*)’: generated/JSBlobBuilder.cpp:255: warning: suggest parentheses around && within || generated/JSBlobBuilder.cpp:255: if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info)))) generate-bindings.pl should generate this line: if ((exec->argumentCount() == 1 && (exec->argument(0).isNull() || (exec->argument(0).isObject() && asObject(exec->argument(0))->inherits(&JSBlob::s_info)))))
Attachments
proposed fix (1.45 KB, patch)
2010-08-12 09:43 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2010-08-12 09:29:36 PDT
I cc-ed Darin, Eric and Anders, you may help to solve this bug, because you know generate-bindings.pl from the beginning: https://bugs.webkit.org/show_bug.cgi?id=5975
Csaba Osztrogonác
Comment 2 2010-08-12 09:31:08 PDT
I think I found it, patch is coming soon.
Csaba Osztrogonác
Comment 3 2010-08-12 09:43:23 PDT
Created attachment 64230 [details] proposed fix
WebKit Commit Bot
Comment 4 2010-08-12 14:56:09 PDT
Comment on attachment 64230 [details] proposed fix Clearing flags on attachment: 64230 Committed r65269: <http://trac.webkit.org/changeset/65269>
WebKit Commit Bot
Comment 5 2010-08-12 14:56:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.