Bug 43073

Summary:

Pick up spec change w.r.t. replacement character and <frameset>

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none
Patch	none

Description Adam Barth 2010-07-27 13:29:28 PDT

Pick up spec change w.r.t. replacement character and <frameset>

Comment 1 Adam Barth 2010-07-27 13:30:47 PDT

Created attachment 62736 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-07-27 13:36:23 PDT

Comment on attachment 62736 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:76
 +  inline bool hasSpecialCharacter(const String& string)
hasNonSpecialCharacter?

Your names are confusing here.

Comment 3 Adam Barth 2010-07-27 13:44:55 PDT

Comment on attachment 62736 [details]
Patch

Yeah, sorry, I dropped the not in the name by accident.

Comment 4 Adam Barth 2010-08-04 17:23:18 PDT

Created attachment 63517 [details]
Patch

Comment 5 Eric Seidel (no email) 2010-08-04 17:31:04 PDT

Comment on attachment 63517 [details]
Patch

OK.

Comment 6 Adam Barth 2010-08-04 17:34:51 PDT

Comment on attachment 63517 [details]
Patch

Clearing flags on attachment: 63517

Committed r64698: <http://trac.webkit.org/changeset/64698>

Comment 7 Adam Barth 2010-08-04 17:34:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Alexey Proskuryakov 2010-08-05 00:02:00 PDT

+        Pick up spec change w.r.t. replacement character and <frameset>
+        https://bugs.webkit.org/show_bug.cgi?id=43073

I would really appreciate a more detailed ChangeLog - there is no easy way to find out what changed here!

Comment 9 Adam Barth 2010-08-05 00:04:39 PDT

There was a discussion in the HTML WG and they decided to allow the <frameset> element to appear after replacement characters for compatibility with some home routers.  They behavior change is documented in the tests.  The "why" is because the WG said so.  There's not much else to say, IMHO.