Summary: | REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steven Kolins <smkolins> | ||||
Component: | CSS | Assignee: | Mark Rowe (bdash) <mrowe> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | abarth, ap, arv, commit-queue, darin, eric.carlson, eric, hyatt, me, mjs, mrowe, peter, usingpond, webkit, webkit.review.bot | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Steven Kolins
2010-07-26 12:09:44 PDT
This broke with <http://trac.webkit.org/changeset/63854>. Sadly r63854 doesn’t mention which bug it is related to. cd "/System/Library/Frameworks/PubSub.framework/Versions/A/Resources/PubSubAgent.app/Contents/Resources/" grep -e "-apple-" -r . Main.css: -apple-text-size-adjust: none; Main.css: -apple-line-clamp: 100%; Main.css: -apple-text-size-adjust: none; grep -e "-khtml-" -r . Main.css: -khtml-user-select: none; Main.css: display: -khtml-box; Main.css: -khtml-box-orient: vertical; Main.css: display: -khtml-box; Main.css: -khtml-box-orient: horizontal; Main.css: -khtml-box-align: baseline; Main.css: -khtml-user-select: none; Main.css: -khtml-margin-top-collapse:discard; Main.css: -khtml-margin-top-collapse:discard; Main.css: -khtml-user-select: none; Main.css:.apple-rss-multi-line-mode .apple-rss-subject { -khtml-box-flex: 60; } Main.css:.apple-rss-multi-line-mode .apple-rss-author { -khtml-box-flex: 40; } Main.css:.apple-rss-single-line-mode .apple-rss-subject { -khtml-box-flex: 1; -khtml-box-flex-group: 1; } Main.css:.apple-rss-single-line-mode .apple-rss-source { -khtml-box-flex: 1; -khtml-box-flex-group: 2; font-size: 12px; } Main.css:.apple-rss-single-line-mode .apple-rss-summary { -khtml-box-flex: 1; -khtml-box-flex-group: 4; } Main.css:.apple-rss-single-line-mode .apple-rss-date { -khtml-box-flex: 1; -khtml-box-flex-group: 100; font-size: 12px; text-align: right; margin-right: 0; } Are the culprits I find it incredibly unlikely that Safari RSS is the only thing that uses -khtml or -apple vendor prefixes. Dashboard widgets, Dashcode templates, and third-party applications (Yahoo! Messenger) all appear to make use of these prefixes in some form. I would like to propose rolling out r63854 and having that issue revisited in a manner that takes backwards-compatibility in to consideration. Created attachment 62599 [details] Patch This reverts only the WebCore portion of r63854. I see no reason to revert the layout test portion of that revision. Attachment 62599 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/css/CSSParser.cpp:5622: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in r64071. http://trac.webkit.org/changeset/64071 might have broken GTK Linux 32-bit Release *** Bug 42896 has been marked as a duplicate of this bug. *** *** Bug 42898 has been marked as a duplicate of this bug. *** |