| Summary: | Re-order whitespace checks in the tokenizer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-07-23 18:19:37 PDT
Created attachment 62482 [details]
Patch
Comment on attachment 62482 [details]
Patch
Interesting. Again, would be nice to have a comment about why they're in this order.
Comment on attachment 62482 [details]
Patch
There's an extensive comment in ASCIIType.h that explains the proper order and has statistics.
Comment on attachment 62482 [details] Patch Rejecting patch 62482 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20715 test cases. animations/play-state.html -> failed Exiting early after 1 failures. 123 tests run. 11.51s total testing time 122 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3567416 Comment on attachment 62482 [details] Patch Bug 42821. Comment on attachment 62482 [details] Patch Clearing flags on attachment: 62482 Committed r64012: <http://trac.webkit.org/changeset/64012> All reviewed patches have been landed. Closing bug. |