| Summary: | Add fast-reject path for InputStreamPreprocessor::peek | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 41123 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-07-23 01:30:30 PDT
Created attachment 62393 [details]
Patch
Comment on attachment 62393 [details]
Patch
Thank you for the comment! Would be nice to see your perf results in the bug, but the % in the ChangeLog is sufficient.
Comment on attachment 62393 [details] Patch Rejecting patch 62393 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20713 test cases. fast/js/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3.html -> failed Exiting early after 1 failures. 8599 tests run. 165.74s total testing time 8598 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3618060 Created attachment 62437 [details]
Patch for landing
Comment on attachment 62437 [details] Patch for landing Rejecting patch 62437 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLTokenizer.h Hunk #1 FAILED at 152. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLTokenizer.h.rej Full output: http://queues.webkit.org/results/3558401 |