Bug 42881 - Add fast-reject path for InputStreamPreprocessor::peek
Summary: Add fast-reject path for InputStreamPreprocessor::peek
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-23 01:30 PDT by Adam Barth
Modified: 2010-07-23 11:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2010-07-23 01:31 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (1.65 KB, patch)
2010-07-23 10:00 PDT, Adam Barth 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-23 01:30:30 PDT 
Add fast-reject path for InputStreamPreprocessor::peek
Comment 1 Adam Barth 2010-07-23 01:31:23 PDT 
Created attachment 62393 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-23 05:06:41 PDT 
Comment on attachment 62393 [details]
Patch

Thank you for the comment!  Would be nice to see your perf results in the bug, but the % in the ChangeLog is sufficient.
Comment 3 WebKit Commit Bot 2010-07-23 08:18:27 PDT 
Comment on attachment 62393 [details]
Patch

Rejecting patch 62393 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20713 test cases.
fast/js/sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3.html -> failed

Exiting early after 1 failures. 8599 tests run.
165.74s total testing time

8598 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output

Full output: http://queues.webkit.org/results/3618060
Comment 4 Adam Barth 2010-07-23 10:00:25 PDT 
Created attachment 62437 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-07-23 11:00:21 PDT 
Comment on attachment 62437 [details]
Patch for landing

Rejecting patch 62437 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTokenizer.h
Hunk #1 FAILED at 152.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/html/HTMLTokenizer.h.rej

Full output: http://queues.webkit.org/results/3558401
Comment 6 Adam Barth 2010-07-23 11:27:12 PDT 
http://trac.webkit.org/changeset/63987