Summary: | Inline HTMLElementStack::top | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 41123 | ||||||||
Attachments: |
|
Description
Adam Barth
2010-07-23 00:58:01 PDT
Created attachment 62389 [details]
Patch
== pre == Running 20 times Ignoring warm-up run (4734) 4185 4244 4196 4192 4210 4200 4240 4217 4254 4240 4260 4263 4259 4280 4265 4253 4321 4268 4288 4289 avg 4246.2 stdev 35.68697241291281 == post == Running 20 times Ignoring warm-up run (4740) 4217 4172 4206 4189 4222 4199 4202 4214 4200 4222 4219 4230 4264 4230 4261 4260 4255 4300 4268 4317 avg 4232.35 stdev 36.32117151194328 Comment on attachment 62389 [details]
Patch
OK, again a comment would be nice. I guess the comments could grow old rather quickly, but I hate how the rest of WebKit has so many needlessly inline functions. You can never tell which were inline because the person was lazy, and which because they tested a benchmark and found it to be a speedup.
Created attachment 62439 [details]
Patch for landing
Comment on attachment 62439 [details] Patch for landing Clearing flags on attachment: 62439 Committed r63990: <http://trac.webkit.org/changeset/63990> All reviewed patches have been landed. Closing bug. |