Bug 42879 - Inline HTMLElementStack::top
Summary: Inline HTMLElementStack::top
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-23 00:58 PDT by Adam Barth
Modified: 2010-07-23 11:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2010-07-23 01:00 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (1.96 KB, patch)
2010-07-23 10:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-23 00:58:01 PDT 
Inline HTMLElementStack::top
Comment 1 Adam Barth 2010-07-23 01:00:51 PDT 
Created attachment 62389 [details]
Patch
Comment 2 Adam Barth 2010-07-23 01:01:19 PDT 
== pre ==

Running 20 times
Ignoring warm-up run (4734)
4185
4244
4196
4192
4210
4200
4240
4217
4254
4240
4260
4263
4259
4280
4265
4253
4321
4268
4288
4289

avg 4246.2
stdev 35.68697241291281

== post ==

Running 20 times
Ignoring warm-up run (4740)
4217
4172
4206
4189
4222
4199
4202
4214
4200
4222
4219
4230
4264
4230
4261
4260
4255
4300
4268
4317

avg 4232.35
stdev 36.32117151194328
Comment 3 Eric Seidel (no email) 2010-07-23 05:04:40 PDT 
Comment on attachment 62389 [details]
Patch

OK, again a comment would be nice.  I guess the comments could grow old rather quickly, but I hate how the rest of WebKit has so many needlessly inline functions.  You can never tell which were inline because the person was lazy, and which because they tested a benchmark and found it to be a speedup.
Comment 4 Adam Barth 2010-07-23 10:08:39 PDT 
Created attachment 62439 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-07-23 11:54:15 PDT 
Comment on attachment 62439 [details]
Patch for landing

Clearing flags on attachment: 62439

Committed r63990: <http://trac.webkit.org/changeset/63990>
Comment 6 WebKit Commit Bot 2010-07-23 11:54:20 PDT 
All reviewed patches have been landed.  Closing bug.