Bug 42803

Summary: Convert DRT list tests from pixel-tests/render tree dumps to text
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, bweinstein, darin, eric, jwieczorek, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 36734, 42938    
Attachments:
Description Flags
[Patch] Part 1 of 2 (Updated tests and expected results)
none
[Patch] Part 2 of 2 (Remove Mac and Windows render-tree/pixel-tests results)
darin: review+
[Patch] Part 1 of 2 (Updated tests and expected results)
none
[Patch] Part 1 of 2 (Updated tests and expected results) darin: review+

Description Daniel Bates 2010-07-21 20:54:29 PDT
With the passing of Bug #37929 and Bug #37930, we can convert a subset of the DRT lists tests from pixel-tests/render tree dumps to text.
Comment 1 Daniel Bates 2010-07-21 21:07:03 PDT
Created attachment 62257 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)
Comment 2 Daniel Bates 2010-07-21 21:10:11 PDT
Created attachment 62258 [details]
[Patch] Part 2 of 2 (Remove Mac and Windows render-tree/pixel-tests results)

Remove the render-tree/pixel-test results for some of the Mac and Windows DRT list tests since we are converting these tests to text.
Comment 3 WebKit Review Bot 2010-07-21 21:14:17 PDT
Attachment 62258 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Daniel Bates 2010-07-21 21:18:08 PDT
Since the patch is fairly large, I thought to break it up into two parts to make it easier to review the changes. Let me know 

[Patch] Part 1 of 2 (Updated tests and expected results): Includes the modifications of the test files so that they dump text. Also includes the text-based expected results and change log entry.

[Patch] Part 2 of 2 (Remove Mac and Windows render-tree/pixel-tests results): The patch removes all of the render-tree/pixel-test results of the converted tests.

I converted the following tests to text:

fast/lists/alpha-boundary-values.html
fast/lists/alpha-list-wrap.html
fast/lists/decimal-leading-zero.html
fast/lists/li-values.html
fast/lists/list-style-type-dynamic-change.html
fast/lists/w3-css3-list-styles-alphabetic.html
fast/lists/w3-css3-list-styles-numeric.html
fast/lists/w3-list-styles.html

Let me know if I should break up either part of this patch further.
Comment 5 Daniel Bates 2010-07-21 21:21:59 PDT
Created attachment 62259 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

Update change log so that the line for "fast/lists/list-style-type-dynamic-change.html" has the remark "Modified to dump as text."
Comment 6 Daniel Bates 2010-07-21 21:45:59 PDT
Created attachment 62261 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

Fix typos in fast/lists/w3-css3-list-styles-numeric.html for binary list-style-type results.
Comment 7 Darin Adler 2010-07-24 12:48:16 PDT
Comment on attachment 62261 [details]
[Patch] Part 1 of 2 (Updated tests and expected results)

These new versions of the tests all seem OK and some even seem great.
Comment 8 Daniel Bates 2010-07-27 20:45:28 PDT
Committed r64186: <http://trac.webkit.org/changeset/64186>
Comment 9 WebKit Review Bot 2010-07-27 21:01:33 PDT
http://trac.webkit.org/changeset/64186 might have broken Qt Linux Release
Comment 10 Daniel Bates 2010-07-28 00:15:56 PDT
(In reply to comment #9)
> http://trac.webkit.org/changeset/64186 might have broken Qt Linux Release

Inadvertently did not remove the platform-specific expected results in the Qt and GTK ports. These platform-specific render-tree/pixel test results are no longer needed since the test dump as text.

Removed these files in changeset 64188 <http://trac.webkit.org/changeset/64188>.