Bug 42688

Summary: WebKitTestRunner needs layoutTestController.setWindowIsKey
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, rakuco, simon.fraser, xan.lopez
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch which fixes Windows
none
Patch andersca: review+

Sam Weinig
Reported 2010-07-20 15:14:32 PDT
WebKitTestRunner needs layoutTestController.setWindowIsKey
Attachments
Patch (24.79 KB, patch)
2011-10-06 12:20 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch which fixes Windows (24.79 KB, patch)
2011-10-06 13:53 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (21.91 KB, patch)
2011-10-10 13:43 PDT, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-07-20 15:32:00 PDT
<rdar://problem/8213853>
Simon Fraser (smfr)
Comment 2 2011-10-06 12:10:36 PDT
*** Bug 69397 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2011-10-06 12:20:44 PDT
Created attachment 109992 [details] Patch
Simon Fraser (smfr)
Comment 4 2011-10-06 13:53:59 PDT
Created attachment 110012 [details] Patch which fixes Windows
Gustavo Noronha (kov)
Comment 5 2011-10-06 15:48:13 PDT
Comment on attachment 110012 [details] Patch which fixes Windows Attachment 110012 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9998003
Darin Adler
Comment 6 2011-10-06 16:33:09 PDT
Comment on attachment 110012 [details] Patch which fixes Windows View in context: https://bugs.webkit.org/attachment.cgi?id=110012&action=review > Tools/ChangeLog:9 > + Since this does window-level stuff, it now has to be asynchronous, so add I don’t understand that. Can’t it be a synchronous call from the web process to the UI process?
Simon Fraser (smfr)
Comment 7 2011-10-06 16:47:10 PDT
(In reply to comment #6) > (From update of attachment 110012 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110012&action=review > > > Tools/ChangeLog:9 > > + Since this does window-level stuff, it now has to be asynchronous, so add > > I don’t understand that. Can’t it be a synchronous call from the web process to the UI process? It could, and I guess we don't care for testing-only methods. I was following Joh's lead on the addChromeInputField stuff.
Simon Fraser (smfr)
Comment 8 2011-10-10 13:43:45 PDT
Created attachment 110395 [details] Patch
Simon Fraser (smfr)
Comment 9 2011-10-10 14:01:09 PDT
http://trac.webkit.org/changeset/97081
Note You need to log in before you can comment on or make changes to this bug.