| Summary: | [Qt] Fix WebKit2 build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abecsi, diegohcg, hausmann, kenneth, webkit.review.bot, zoltan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 42830 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Balazs Kelemen
2010-07-20 06:37:57 PDT
Created attachment 62068 [details]
proposed patch
Attachment 62068 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/qt/WebContextQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 62077 [details]
proposed patch - fixed fix
Attachment 62077 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/qt/WebContextQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 62077 [details]
proposed patch - fixed fix
The patch has been outdated, I will update soon.
Created attachment 62310 [details]
proposed patch
Comment on attachment 62310 [details]
proposed patch
Buildfix committed in revision 63898.
Issue fixed, closing bug. |