Bug 42510

Summary:

[Qt] Canvas: Wrong internal positioning of drawImage() shadows

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

HTML5, Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

42508

Bug Blocks:

Attachments:

Description	Flags
Proposed patch	none

Description Andreas Kling 2010-07-17 18:27:56 PDT

There is a bug in the internal (in-shadow) positioning of shadows generated for drawImage().
They are offset by the the 'destination' rect twice.

This change fixes the following in-tree tests:
- canvas/philip/tests/2d.shadow.canvas.alpha.html
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- canvas/philip/tests/2d.shadow.canvas.transparent.2.html
- canvas/philip/tests/2d.shadow.image.alpha.html
- canvas/philip/tests/2d.shadow.image.transparent.1.html
- canvas/philip/tests/2d.shadow.image.transparent.2.html

Comment 1 Andreas Kling 2010-07-17 18:31:51 PDT

Created attachment 61894 [details]
Proposed patch

Note that this patch depends on bug 42508 for the drawImage(canvas, ...) part.

Comment 2 Andreas Kling 2010-07-19 07:28:02 PDT

Comment on attachment 61894 [details]
Proposed patch

Clearing flags on attachment: 61894

Committed r63657: <http://trac.webkit.org/changeset/63657>

Comment 3 Andreas Kling 2010-07-19 07:28:12 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 WebKit Review Bot 2010-07-19 07:47:39 PDT

http://trac.webkit.org/changeset/63657 might have broken Qt Linux Release