Summary: | SVG JavaScript bindings are busted in latest WebCore+SVG | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | SVG | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, ggaren, mjs | ||||||||
Priority: | P2 | Keywords: | SVGHitList | ||||||||
Version: | 420+ | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Bug Depends on: | 5975 | ||||||||||
Bug Blocks: | 4624, 9190 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-08-01 03:13:49 PDT
Created attachment 3192 [details]
One example of a busted SVG (which used to work)
Ben is working on this one. Actually, this is going to require more heavy lifting than ben will be able to give us. Maciej or I need to re- work the underlying WebCore javascript bindings to be autogenerated, and then make SVG use those autogenerated bindings as well. With KDOM now removed from WebCore+SVG it's no longer possible for the SVG javascript bindings to sit on top of KDOM's bindings, but rather they need to be ported over to WebCore's once WebCore's bindings are fixed to be autogenerated. Adding Regression keyword. Basic DOM autobinding support has been landed. It will probably be a couple more weeks before it's ready to support SVG however. Marking as P2, and adding to the SVG HitList. We could never ship SVG w/o some form of SVG JS bindings. Created attachment 8601 [details]
First stab and turning some of these back on
This patch is not quite ready for review. I'm posting it hear for discussion purposes.
Created attachment 8610 [details]
Much better patch, ready for review.
This patch also has some various style cleanups (sorry).
Comment on attachment 8610 [details]
Much better patch, ready for review.
Some comments:
- if (@{$dataNode->parents} > 1) {
- die "A class can't have more than one parent";
- }
+ #if (@{$dataNode->parents} > 1) {
+ # die "A class can't have more than one parent";
+ #}
There should be a comment explaining why this is commented out.
I think the IDL files should be LGPL
|