Bug 42431

Summary: Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2010-07-15 17:40:59 PDT
Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
Comment 1 Adam Barth 2010-07-15 17:47:00 PDT
Created attachment 61754 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-15 18:34:55 PDT
Comment on attachment 61754 [details]
Patch

LayoutTests/platform/mac/fast/css/style-parsed-outside-head-expected.txt:5
 +      RenderBlock (anonymous) at (0,0) size 785x18
You some how ended up with text content before the <body>.  That seems wrong.  I think your change is not quite right. I think you need to check that it's only whitespace before inserting it before the body.
Comment 3 Adam Barth 2010-07-15 20:45:56 PDT
Created attachment 61762 [details]
Patch
Comment 4 WebKit Commit Bot 2010-07-15 21:55:41 PDT
Comment on attachment 61762 [details]
Patch

Rejecting patch 61762 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
hive
	M	LayoutTests/webarchive/test-object-data-expected.webarchive
	M	LayoutTests/webarchive/test-script-src-expected.webarchive
	M	LayoutTests/webarchive/test-table-background-expected.webarchive
	M	LayoutTests/webarchive/test-td-background-expected.webarchive
	M	WebCore/ChangeLog
	M	WebCore/html/LegacyHTMLTreeBuilder.cpp
Merge conflict during commit: MERGE request failed on '/repository/webkit/trunk': Conflict at '/trunk/WebCore/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3348716
Comment 5 Eric Seidel (no email) 2010-07-15 21:57:42 PDT
Comment on attachment 61762 [details]
Patch

I'm surprised that's not a recoverable error.
Comment 6 Adam Barth 2010-07-15 22:16:27 PDT
Comment on attachment 61762 [details]
Patch

Clearing flags on attachment: 61762

Committed r63517: <http://trac.webkit.org/changeset/63517>
Comment 7 Adam Barth 2010-07-15 22:16:33 PDT
All reviewed patches have been landed.  Closing bug.