Bug 42366

Summary: [Qt] Improve test coverage for the QScriptValue
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Severity: Normal CC: cmarcelo, commit-queue, jedrzej.nowacki, kenneth, kent.hansen
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Description Flags
Fix v1 none

Description Jędrzej Nowacki 2010-07-15 06:41:36 PDT
QtScript have a great test coverage, but it could be even better.

Now the QScriptValue autotest use a set of values to check API, the set is initialized before each test case. Because of a lazy nature of a QScriptValue object, it is not perfect. The value after first contact with an engine get bound to it, so all other tests check modified version of the value. This was the main cause why bug 42363 was found in a benchmarks and not in an autotests.

I propose to recreate all values before each test.
Comment 1 Jędrzej Nowacki 2010-07-27 08:07:04 PDT
Created attachment 62691 [details]
Fix v1
Comment 2 Kenneth Rohde Christiansen 2010-07-27 14:16:33 PDT
Comment on attachment 62691 [details]
Fix v1

Good work!
Comment 3 WebKit Commit Bot 2010-07-27 15:16:27 PDT
Comment on attachment 62691 [details]
Fix v1

Clearing flags on attachment: 62691

Committed r64165: <http://trac.webkit.org/changeset/64165>
Comment 4 WebKit Commit Bot 2010-07-27 15:16:31 PDT
All reviewed patches have been landed.  Closing bug.