Bug 42096

Summary:

HTMLTreeBuilder needs to support mixing SVG and MathML content

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	abarth: review+

Description Eric Seidel (no email) 2010-07-12 11:18:55 PDT

HTMLTreeBuilder needs to support mixing SVG and MathML content

Comment 1 Eric Seidel (no email) 2010-07-12 11:32:15 PDT

Created attachment 61249 [details]
Patch

Comment 2 Adam Barth 2010-07-12 13:31:48 PDT

Comment on attachment 61249 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:1161
 +          return (token.name() != MathMLNames::mglyphTag
Why ( .. ) ?  We don't need those in C++.

WebCore/html/HTMLTreeBuilder.cpp:1489
 +          // FIXME: We're missing a bunch of if branches here.
I'd remove this comment.

Comment 3 Eric Seidel (no email) 2010-07-12 13:32:49 PDT

(In reply to comment #2)
> (From update of attachment 61249 [details])
> WebCore/html/HTMLTreeBuilder.cpp:1161
>  +          return (token.name() != MathMLNames::mglyphTag
> Why ( .. ) ?  We don't need those in C++.

Will remove.

> WebCore/html/HTMLTreeBuilder.cpp:1489
>  +          // FIXME: We're missing a bunch of if branches here.
> I'd remove this comment.

That goes away two patches later. :)

Comment 4 Eric Seidel (no email) 2010-07-12 14:13:31 PDT

Committed r63116: <http://trac.webkit.org/changeset/63116>