Summary: | [Qt] REGRESSION?(62951): media tests fail | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Nancy Piedra <nancy.piedra> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | abecsi, diegohcg, hausmann, menard, nancy.piedra, pnormand, vestbo, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 86679 | ||||||
Bug Blocks: | 79666 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-07-12 10:43:46 PDT
With QtMobility master & Qt 4.7.2 on Linux, restore-from-page-cache passes for me. But video-can-play-type still fails. I think that MediaPlayerPrivateQt.cpp does not implement to the HTML5 specification. I will take a look at that. The root cause of the video-can-play-type has been identified as an error in QtMobility in the following bug: https://bugs.webkit.org/show_bug.cgi?id=53275 This bug can probably be closed as a duplicate of 53275. Acutally, this bug should be kept open because still some changes will be needed to the Qt MediaPlayer implementation to pass this test. Created attachment 142262 [details]
Patch
(In reply to comment #4) > Created an attachment (id=142262) [details] > Patch Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. (In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=142262) [details] [details] > > Patch > > Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. What about the http/tests/media? I suspect some of them pass as well. (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Created an attachment (id=142262) [details] [details] [details] > > > Patch > > > > Let's give a shot and we can skip some of them if needed. Some coverage (395) is better than 0 coverage. > > What about the http/tests/media? I suspect some of them pass as well. One thing at a time :) Comment on attachment 142262 [details] Patch Clearing flags on attachment: 142262 Committed r117332: <http://trac.webkit.org/changeset/117332> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 86679 |