Bug 42026

Summary: [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, svillar, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
gtk3build.diff none

Philippe Normand
Reported 2010-07-10 03:35:27 PDT
WebKitTools/Scripts/webkitdirs.pm line 599 hardcodes libwebkitgtk-1.0.so but if webkit is compiled against gtk3 it should be libwebkitgtk-3.0.so To test: run-launcher --gtk Error: Can't find built framework at "/home/phil/gst/jhbuild/build/WebKit/WebKitBuild/gtk-fullscreen2/Release/JavaScriptCore/../.libs/libwebkitgtk-1.0.so".
Attachments
gtk3build.diff (2.07 KB, patch)
2010-08-23 07:26 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-07-10 03:39:34 PDT
Because we support build of gtk2 and gtk3 at the moment I think it'd make sense to have: build-webkit --gtk3 and the current --gtk option (renamed to --gtk2?) instead of build-webkit --gtk --use-gtk=3.0 This be used for the launcher too: run-launcher --gtk2 run-launcher --gtk3
Martin Robinson
Comment 2 2010-07-10 14:24:02 PDT
Why not just have the script detect what the appropriate version of the library is, by looking at the directory contents?
Xan Lopez
Comment 3 2010-07-10 14:32:49 PDT
(In reply to comment #2) > Why not just have the script detect what the appropriate version of the library is, by looking at the directory contents? You could have both libraries, so a switch might make sense to force one or the other.
Martin Robinson
Comment 4 2010-07-10 14:38:12 PDT
True, I think that only if both exist should an extra switch be required to select the right one.
Philippe Normand
Comment 5 2010-07-12 00:01:23 PDT
The less intrusive is probably to assume --gtk is for gtk2 (for now) and add a --gtk3 switch. So later on when we drop support for gtk2, just assume --gtk is for gtk3 and drop --gtk3... What ya think? Renaming the current --gtk to --gtk2 would imply we need to update the buildbot scripts at least. It might also confuse the current people who use --gtk.
Xan Lopez
Comment 6 2010-08-23 07:26:38 PDT
Created attachment 65114 [details] gtk3build.diff So, let's do first what Martin suggested. It should work well enough for our common work routine, and if anybody needs something more sophisticated he can go ahead and write it.
Martin Robinson
Comment 7 2010-08-23 08:06:23 PDT
Comment on attachment 65114 [details] gtk3build.diff LGTM!
Sergio Villar Senin
Comment 8 2010-08-23 08:27:57 PDT
*** Bug 44425 has been marked as a duplicate of this bug. ***
Xan Lopez
Comment 9 2010-08-23 08:33:40 PDT
Comment on attachment 65114 [details] gtk3build.diff Landed as r65811.
Xan Lopez
Comment 10 2010-08-23 08:33:50 PDT
Closing bug.
Note You need to log in before you can comment on or make changes to this bug.