Bug 41991

Summary: HTML5 tree builder should pass some LayoutTests
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-07-09 14:40:35 PDT
HTML5 tree builder should pass some LayoutTests
Attachments
Patch (2.60 KB, patch)
2010-07-09 14:43 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.91 KB, patch)
2010-07-09 14:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-09 14:43:02 PDT
Created attachment 61101 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-09 14:46:56 PDT
Comment on attachment 61101 [details] Patch WebCore/html/HTMLConstructionSite.cpp:103 + RefPtr<Node> child = prpChild; This causes us to end up taking an extra reference. We should steal a raw pointer for our ASSERTs. parserAddChild can never fail. Why do we need to be attaching text nodes? Is something wrong in the lazy attach codepath? Does DRT need to be calling some layout method that it's not?
Eric Seidel (no email)
Comment 3 2010-07-09 14:48:37 PDT
Comment on attachment 61101 [details] Patch You need to at least add a FIXME about the extra ref problem. But it seems silly/lazy to not just fix it now. :p CC'd James R. about understanding the Text node lazy-attach failure problem.
Adam Barth
Comment 4 2010-07-09 14:53:04 PDT
Created attachment 61105 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-07-09 20:48:07 PDT
Comment on attachment 61105 [details] Patch for landing Clearing flags on attachment: 61105 Committed r63037: <http://trac.webkit.org/changeset/63037>
WebKit Commit Bot
Comment 6 2010-07-09 20:48:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.