Bug 41943

Summary: Add basic "in foreign content" support to the TreeBuilder
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch abarth: review+

Description Eric Seidel (no email) 2010-07-09 02:08:59 PDT
Add basic "in foreign content" support to the TreeBuilder
Comment 1 Eric Seidel (no email) 2010-07-09 02:14:09 PDT
Created attachment 61020 [details]
Patch
Comment 2 Adam Barth 2010-07-09 02:36:36 PDT
Comment on attachment 61020 [details]
Patch

Cool!

WebCore/html/HTMLElementStack.cpp:336
 +  bool HTMLElementStack::isOnlyHTMLElementsInScope() const
hasOnlyHTMLElementsInScope ?

WebCore/html/HTMLTreeBuilder.cpp:1395
 +          else
This doesn't work right if MATHML is turned on and SVG is off.

WebCore/html/HTMLTreeBuilder.cpp:1402
 +          m_tree.insertForeignElement(token, m_tree.currentElement()->namespaceURI());
Why do we re-read this instead of using currentNamespace?

WebCore/html/HTMLTreeBuilder.cpp:2194
 +          if (token.name() == SVGNames::scriptTag && m_tree.currentElement()->hasTagName(SVGNames::scriptTag)) {
Missing #ifdef SVG

WebCore/html/HTMLTreeBuilder.cpp:2236
 +      }
insert blank line
Comment 3 Eric Seidel (no email) 2010-07-09 03:18:00 PDT
Oops, this got landed with another change as part of http://trac.webkit.org/changeset/62926.