Bug 41932 – [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Kent Tamura]

[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm

[Kent Tamura]

Created attachment 61017 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 61017 [details]
Patch

I don't think there is much I can review here.  Only really rubber-stamp.  Assuming it works for Chromium, rs=me.

[Joseph Pecoraro]

Comment on attachment 61017 [details]
Patch

> +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> +        case OuterSpinButtonPart: {
> +            static const int stepperMargin[4] = { 0, 0, 0, 0};

Probably a negligible style issue. Missing a space at the end? "0 };"

[Kent Tamura]

Committed r63514: <http://trac.webkit.org/changeset/63514>

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 61017 [details])
> > +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> > +        case OuterSpinButtonPart: {
> > +            static const int stepperMargin[4] = { 0, 0, 0, 0};
> 
> Probably a negligible style issue. Missing a space at the end? "0 };"

Thank you for pointing it out.
I have fixed it and the same one in ThemeMac.mm by http://trac.webkit.org/changeset/63518

[WebKit Review Bot]

http://trac.webkit.org/changeset/63514 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63514
http://trac.webkit.org/changeset/63515
http://trac.webkit.org/changeset/63516
http://trac.webkit.org/changeset/63517
http://trac.webkit.org/changeset/63518