Bug 41932

Summary: [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Product: WebKit Reporter: Kent Tamura <tkent>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 38570    
Attachments:
Description Flags
Patch eric: review+

Description Kent Tamura 2010-07-08 23:01:18 PDT
[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Comment 1 Kent Tamura 2010-07-09 01:58:58 PDT
Created attachment 61017 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-15 21:22:10 PDT
Comment on attachment 61017 [details]
Patch

I don't think there is much I can review here.  Only really rubber-stamp.  Assuming it works for Chromium, rs=me.
Comment 3 Joseph Pecoraro 2010-07-15 21:32:16 PDT
Comment on attachment 61017 [details]
Patch

> +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> +        case OuterSpinButtonPart: {
> +            static const int stepperMargin[4] = { 0, 0, 0, 0};

Probably a negligible style issue. Missing a space at the end? "0 };"
Comment 4 Kent Tamura 2010-07-15 21:55:28 PDT
Committed r63514: <http://trac.webkit.org/changeset/63514>
Comment 5 Kent Tamura 2010-07-15 22:19:04 PDT
(In reply to comment #3)
> (From update of attachment 61017 [details])
> > +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> > +        case OuterSpinButtonPart: {
> > +            static const int stepperMargin[4] = { 0, 0, 0, 0};
> 
> Probably a negligible style issue. Missing a space at the end? "0 };"

Thank you for pointing it out.
I have fixed it and the same one in ThemeMac.mm by http://trac.webkit.org/changeset/63518