Bug 41839

Summary: [Qt] QScriptEngine should work correctly even after global object changes
Product: WebKit Reporter: Jędrzej Nowacki <jedrzej.nowacki>
Component: JavaScriptCoreAssignee: Jędrzej Nowacki <jedrzej.nowacki>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, jedrzej.nowacki, kent.hansen
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31863    
Attachments:
Description Flags
Fix v1
none
Fix v1.01 none

Description Jędrzej Nowacki 2010-07-08 01:18:29 PDT
Some algorithms in the QScriptValue and in the QScriptEngine (like QSV::isError() method) are not prepared for Global Object changes. It would be nice to keep a reference to some of global object's properties in QScriptEnginePrivate, for future use.
Comment 1 Jędrzej Nowacki 2010-07-14 04:42:54 PDT
Created attachment 61502 [details]
Fix v1
Comment 2 Jędrzej Nowacki 2010-07-14 06:45:38 PDT
Created attachment 61514 [details]
Fix v1.01

Rebased against trunk
Comment 3 Kenneth Rohde Christiansen 2010-07-14 06:51:51 PDT
Comment on attachment 61514 [details]
Fix v1.01

Nice that you are concentrating all method that will need C api in the future. r=me
Comment 4 WebKit Commit Bot 2010-07-14 07:35:18 PDT
Comment on attachment 61514 [details]
Fix v1.01

Clearing flags on attachment: 61514

Committed r63318: <http://trac.webkit.org/changeset/63318>
Comment 5 WebKit Commit Bot 2010-07-14 07:35:22 PDT
All reviewed patches have been landed.  Closing bug.