Bug 41688

Summary: Add processing for "in cell" mode and end tag processing for "in row"
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, Ms2ger
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-07-06 05:36:31 PDT
Add processing for "in cell" mode and end tag processing for "in row"
Attachments
Patch (29.16 KB, patch)
2010-07-06 05:43 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-06 05:43:09 PDT
Created attachment 60623 [details] Patch
Adam Barth
Comment 2 2010-07-06 09:43:21 PDT
Comment on attachment 60623 [details] Patch WebCore/html/HTMLTreeBuilder.cpp:760 + void HTMLTreeBuilder::closeTheCell() I like the insert-to-code ratio in this function.
Adam Barth
Comment 3 2010-07-06 10:28:53 PDT
Comment on attachment 60623 [details] Patch Clearing flags on attachment: 60623 Committed r62563: <http://trac.webkit.org/changeset/62563>
Adam Barth
Comment 4 2010-07-06 10:28:58 PDT
All reviewed patches have been landed. Closing bug.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 5 2010-07-06 11:11:41 PDT
(In reply to comment #2) > (From update of attachment 60623 [details]) > WebCore/html/HTMLTreeBuilder.cpp:760 > + void HTMLTreeBuilder::closeTheCell() > I like the insert-to-code ratio in this function. And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag).
Adam Barth
Comment 6 2010-07-06 11:24:10 PDT
> And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag). Patches welcome. :)
Note You need to log in before you can comment on or make changes to this bug.