Bug 41688

Summary:

Add processing for "in cell" mode and end tag processing for "in row"

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, Ms2ger

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none

Description Eric Seidel (no email) 2010-07-06 05:36:31 PDT

Add processing for "in cell" mode and end tag processing for "in row"

Comment 1 Eric Seidel (no email) 2010-07-06 05:43:09 PDT

Created attachment 60623 [details]
Patch

Comment 2 Adam Barth 2010-07-06 09:43:21 PDT

Comment on attachment 60623 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:760
 +  void HTMLTreeBuilder::closeTheCell()
I like the insert-to-code ratio in this function.

Comment 3 Adam Barth 2010-07-06 10:28:53 PDT

Comment on attachment 60623 [details]
Patch

Clearing flags on attachment: 60623

Committed r62563: <http://trac.webkit.org/changeset/62563>

Comment 4 Adam Barth 2010-07-06 10:28:58 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2010-07-06 11:11:41 PDT

(In reply to comment #2)
> (From update of attachment 60623 [details])
> WebCore/html/HTMLTreeBuilder.cpp:760
>  +  void HTMLTreeBuilder::closeTheCell()
> I like the insert-to-code ratio in this function.

And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag).

Comment 6 Adam Barth 2010-07-06 11:24:10 PDT

> And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag).

Patches welcome.  :)