Bug 41627

Summary: Implement InSelectMode
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2010-07-05 11:29:55 PDT
Implement InSelectMode
Attachments
Patch (5.19 KB, patch)
2010-07-05 11:30 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (12.11 KB, patch)
2010-07-05 20:46 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.15 KB, patch)
2010-07-05 21:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-05 11:30:48 PDT
Created attachment 60559 [details] Patch
Adam Barth
Comment 2 2010-07-05 20:46:55 PDT
Created attachment 60577 [details] Patch
Eric Seidel (no email)
Comment 3 2010-07-05 20:58:47 PDT
Comment on attachment 60577 [details] Patch WebCore/html/HTMLTreeBuilder.cpp:913 + insertElement(token); Why no return after this? We need to figure out what the right pattern here is. WebCore/html/HTMLTreeBuilder.cpp:924 + insertElement(token); Here again? No return? Looks OK, I think.
Adam Barth
Comment 4 2010-07-05 21:03:07 PDT
Created attachment 60578 [details] Patch for landing
WebKit Commit Bot
Comment 5 2010-07-05 21:58:29 PDT
Comment on attachment 60578 [details] Patch for landing Clearing flags on attachment: 60578 Committed r62519: <http://trac.webkit.org/changeset/62519>
WebKit Commit Bot
Comment 6 2010-07-05 21:58:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.