Bug 41627

Summary:

Implement InSelectMode

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

41123

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Adam Barth 2010-07-05 11:29:55 PDT

Implement InSelectMode

Comment 1 Adam Barth 2010-07-05 11:30:48 PDT

Created attachment 60559 [details]
Patch

Comment 2 Adam Barth 2010-07-05 20:46:55 PDT

Created attachment 60577 [details]
Patch

Comment 3 Eric Seidel (no email) 2010-07-05 20:58:47 PDT

Comment on attachment 60577 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:913
 +              insertElement(token);
Why no return after this?  We need to figure out what the right pattern here is.

WebCore/html/HTMLTreeBuilder.cpp:924
 +              insertElement(token);
Here again?  No return?

Looks OK, I think.

Comment 4 Adam Barth 2010-07-05 21:03:07 PDT

Created attachment 60578 [details]
Patch for landing

Comment 5 WebKit Commit Bot 2010-07-05 21:58:29 PDT

Comment on attachment 60578 [details]
Patch for landing

Clearing flags on attachment: 60578

Committed r62519: <http://trac.webkit.org/changeset/62519>

Comment 6 WebKit Commit Bot 2010-07-05 21:58:34 PDT

All reviewed patches have been landed.  Closing bug.