Bug 41591

Summary: Add </table> support for "in table" insertion mode
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing commit-queue: commit-queue-

Description Eric Seidel (no email) 2010-07-04 21:57:18 PDT
Add </table> support for "in table" insertion mode
Comment 1 Eric Seidel (no email) 2010-07-04 22:02:45 PDT
Created attachment 60493 [details]
Patch
Comment 2 Adam Barth 2010-07-04 22:05:51 PDT
Comment on attachment 60493 [details]
Patch

We're not supposed to return after the fragment mode parse error?
Comment 3 Eric Seidel (no email) 2010-07-05 11:32:49 PDT
Created attachment 60561 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-07-05 12:54:04 PDT
Comment on attachment 60561 [details]
Patch for landing

Rejecting patch 60561 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
ed.txt
Hunk #1 FAILED at 4940.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file WebCore/ChangeLog
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 25.
Hunk #3 FAILED at 44.
Hunk #4 FAILED at 66.
4 out of 4 hunks FAILED -- saving rejects to file WebCore/ChangeLog.rej
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 succeeded at 1064 (offset -29 lines).
Hunk #2 succeeded at 1227 (offset -29 lines).
patching file WebCore/html/HTMLTreeBuilder.h

Full output: http://webkit-commit-queue.appspot.com/results/3391257
Comment 5 Adam Barth 2010-07-05 13:54:37 PDT
Your changelog is all messed up.
Comment 6 Adam Barth 2010-07-05 14:25:27 PDT
Committed r62507: <http://trac.webkit.org/changeset/62507>