Summary: | Add basic <col> support to the treebuilder | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41123 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-07-04 21:10:53 PDT
Created attachment 60492 [details]
Patch
Comment on attachment 60492 [details]
Patch
Ok.. Too bad we fail one of the new tests.
Comment on attachment 60492 [details] Patch Rejecting patch 60492 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: (offset 19 lines). Hunk #2 FAILED at 1405. Hunk #3 FAILED at 5656. 2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Hunk #1 FAILED at 4937. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #2 succeeded at 784 (offset -3 lines). Full output: http://webkit-commit-queue.appspot.com/results/3419170 Comment on attachment 60492 [details] Patch Rejecting patch 60492 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: (offset 19 lines). Hunk #2 FAILED at 1405. Hunk #3 FAILED at 5656. 2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file LayoutTests/html5lib/runner-expected.txt Hunk #1 FAILED at 4937. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #2 succeeded at 784 (offset -3 lines). Full output: http://webkit-commit-queue.appspot.com/results/3402269 Comment on attachment 60492 [details]
Patch
Cascading failure from earlier flaky test trouble. :(
Comment on attachment 60492 [details] Patch Clearing flags on attachment: 60492 Committed r62500: <http://trac.webkit.org/changeset/62500> All reviewed patches have been landed. Closing bug. |