Bug 41590 - Add basic <col> support to the treebuilder
Summary: Add basic <col> support to the treebuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-04 21:10 PDT by Eric Seidel (no email)
Modified: 2010-07-05 13:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.24 KB, patch)
2010-07-04 21:16 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-04 21:10:53 PDT
Add basic <col> support to the treebuilder
Comment 1 Eric Seidel (no email) 2010-07-04 21:16:47 PDT
Created attachment 60492 [details]
Patch
Comment 2 Adam Barth 2010-07-04 21:34:29 PDT
Comment on attachment 60492 [details]
Patch

Ok.. Too bad we fail one of the new tests.
Comment 3 WebKit Commit Bot 2010-07-04 22:13:32 PDT
Comment on attachment 60492 [details]
Patch

Rejecting patch 60492 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
(offset 19 lines).
Hunk #2 FAILED at 1405.
Hunk #3 FAILED at 5656.
2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej
patching file LayoutTests/html5lib/runner-expected.txt
Hunk #1 FAILED at 4937.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #2 succeeded at 784 (offset -3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3419170
Comment 4 WebKit Commit Bot 2010-07-05 12:29:18 PDT
Comment on attachment 60492 [details]
Patch

Rejecting patch 60492 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
(offset 19 lines).
Hunk #2 FAILED at 1405.
Hunk #3 FAILED at 5656.
2 out of 3 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej
patching file LayoutTests/html5lib/runner-expected.txt
Hunk #1 FAILED at 4937.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #2 succeeded at 784 (offset -3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3402269
Comment 5 Eric Seidel (no email) 2010-07-05 12:54:29 PDT
Comment on attachment 60492 [details]
Patch

Cascading failure from earlier flaky test trouble. :(
Comment 6 Adam Barth 2010-07-05 13:03:54 PDT
Comment on attachment 60492 [details]
Patch

Clearing flags on attachment: 60492

Committed r62500: <http://trac.webkit.org/changeset/62500>
Comment 7 Adam Barth 2010-07-05 13:03:59 PDT
All reviewed patches have been landed.  Closing bug.