Bug 41588

Summary: Add basic "in row" mode to support <td> insertion
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-07-04 19:22:32 PDT
Add basic "in row" mode to support <td> insertion
Attachments
Patch (14.50 KB, patch)
2010-07-04 19:46 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-04 19:46:41 PDT
Created attachment 60489 [details] Patch
WebKit Commit Bot
Comment 2 2010-07-04 21:59:36 PDT
Comment on attachment 60489 [details] Patch Rejecting patch 60489 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: nner-expected.txt Hunk #1 FAILED at 4936. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file LayoutTests/html5lib/runner.html Hunk #1 FAILED at 60. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner.html.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file WebCore/html/HTMLElementStack.cpp patching file WebCore/html/HTMLElementStack.h patching file WebCore/html/HTMLTreeBuilder.cpp Full output: http://webkit-commit-queue.appspot.com/results/3402240
Adam Barth
Comment 3 2010-07-05 11:32:26 PDT
Comment on attachment 60489 [details] Patch In theory, this should land fine now that Bug 41582 is in the queue.
WebKit Commit Bot
Comment 4 2010-07-05 12:16:10 PDT
Comment on attachment 60489 [details] Patch Rejecting patch 60489 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Last 500 characters of output: nner-expected.txt Hunk #1 FAILED at 4936. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej patching file LayoutTests/html5lib/runner.html Hunk #1 FAILED at 60. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner.html.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLElementStack.cpp patching file WebCore/html/HTMLElementStack.h patching file WebCore/html/HTMLTreeBuilder.cpp Full output: http://webkit-commit-queue.appspot.com/results/3409265
Eric Seidel (no email)
Comment 5 2010-07-05 12:54:19 PDT
Comment on attachment 60489 [details] Patch Cascading failure from earlier flaky test trouble. :(
Adam Barth
Comment 6 2010-07-05 13:02:21 PDT
Comment on attachment 60489 [details] Patch Clearing flags on attachment: 60489 Committed r62499: <http://trac.webkit.org/changeset/62499>
Adam Barth
Comment 7 2010-07-05 13:02:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.