Bug 41587

Summary: Add basic "in table body" mode to support <tr> insertion
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-07-04 18:54:45 PDT
Add basic "in table body" mode to support <tr> insertion
Attachments
Patch (8.48 KB, patch)
2010-07-04 19:01 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-07-04 19:01:35 PDT
Created attachment 60488 [details] Patch
Adam Barth
Comment 2 2010-07-04 21:28:12 PDT
Comment on attachment 60488 [details] Patch WebCore/html/HTMLTreeBuilder.cpp:787 + m_openElements.popUntilTableBodyScopeMarker(); // How is there ever anything to pop? We could add an assert that this is a nop if we want to learn. WebCore/html/HTMLTreeBuilder.cpp:805 + notImplemented(); // process using "in table" rules Our strategy here has been to move that code into a separate function that we can call.
WebKit Commit Bot
Comment 3 2010-07-04 21:45:48 PDT
Comment on attachment 60488 [details] Patch Clearing flags on attachment: 60488 Committed r62474: <http://trac.webkit.org/changeset/62474>
WebKit Commit Bot
Comment 4 2010-07-04 21:45:53 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 5 2010-07-05 10:56:45 PDT
Yes, we can (and should) add such an ASSERT at some point. :)
Note You need to log in before you can comment on or make changes to this bug.